Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

111 expose astra authentication #132

Merged
merged 6 commits into from
Mar 10, 2022
Merged

111 expose astra authentication #132

merged 6 commits into from
Mar 10, 2022

Conversation

alexeiakimov
Copy link
Contributor

The present PR provides

  1. Updates to the existing code to be compatible with the cassandra-sys-rs after the later was upgraded to support C++ driver version 2.16.0
  2. New API for setting the cloud secure connection bundle
  3. A simple example of how to use cloud secure connection bundles

At the moment the PR is a draft, the following items are pending

  1. Migration to the new new release of cassandra-sys-rs
  2. Updating the changelog and other documents.

@kw217 Could you please review. Thank you.

kw217
kw217 requested changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@kw217 kw217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far - thanks! Please make sure you mention the breaking change in the changelog; I don't think it's important enough to call out in the README with a migration guide though.
Please can you fix the broken build? It looks like it needs to pick up a newer version of the Cassandra driver - take a look at what I did on cassandra-sys cassandra-rs/cassandra-sys-rs#40 to see what needs to be done.

src/cassandra/error.rs Show resolved Hide resolved
kw217
kw217 requested changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@kw217 kw217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexeiakimov !
I've now released cassandra-sys-rs 1.0.0; please can you pick that up, and also rebase onto the current master here? Then I think we will be good to go!

@kw217 kw217 mentioned this pull request Mar 9, 2022
Closed
Alexey Akimov and others added 6 commits March 9, 2022 23:31
@alexeiakimov
cassandra-rs#111 the version of cassandra-sys-rs uses C++ driver 2.16.0.
b2446be 
Signed-off-by: Alexey Akimov <alexey@alexey.qbeast>
@alexeiakimov
cassandra-rs#111 methods for setting cloud secure connection bundle a…
cc81b5b 
…re added to Cluster.

Signed-off-by: Alexey Akimov <alexey@alexey.qbeast>
@alexeiakimov
cassandra-rs#111 an example of how to use secure connection bundle
bde1f23 
Signed-off-by: Alexey Akimov <alexey@qbeast.io>
@alexeiakimov
cassandra-rs#111 CassErrorCode is marked with non_exhaustive, build w…
3d4ae50 
…orkflow is migrated to C++ driver version 2.16.0.

Signed-off-by: Alexey Akimov <alexey@qbeast.io>
@alexeiakimov
cassandra-rs#111 The changelog is updated to reflect the migration to…
a6f6428 
… C++ Driver version 2.16.

Signed-off-by: Alexey Akimov <alexey@qbeast.io>
@alexeiakimov
cassandra-rs#111 cassandra-cpp-sys version is upgraded to 1.0.0.
4a2b3bc 
Signed-off-by: Alexey Akimov <alexey@qbeast.io>
@alexeiakimov alexeiakimov force-pushed the 111-expose-astra-authentication branch from 72d5ef3 to 4a2b3bc Compare March 9, 2022 22:38
@alexeiakimov
Copy link
Contributor Author

Thanks @alexeiakimov ! I've now released cassandra-sys-rs 1.0.0; please can you pick that up, and also rebase onto the current master here? Then I think we will be good to go!

Thank you. Done.

@alexeiakimov alexeiakimov requested a review from kw217 March 9, 2022 22:40
kw217
kw217 approved these changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@kw217 kw217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @alexeiakimov !

@kw217 kw217 merged commit f8920d2 into cassandra-rs:master Mar 10, 2022
@kw217 kw217 mentioned this pull request Mar 10, 2022
Closed
@kw217
Copy link
Collaborator

kw217 commented Mar 10, 2022

I'm keen to do a new release for this, but I have a few other things to check first. Do you have an urgent need for this, or are you OK to wait for a week or so?

@alexeiakimov
Copy link
Contributor Author

@kw217 Thank you so much. No it is not urgent, please take you time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kw217 kw217 kw217 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexeiakimov @kw217