Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detail to CONTRIBUTING #41

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Conversation

kw217
Copy link
Collaborator

@kw217 kw217 commented Mar 4, 2022

Pick up details from #38 and record for posterity.

Signed-off-by: Keith Wansbrough <Keith.Wansbrough@metaswitch.com>
@kw217 kw217 requested a review from angusi March 4, 2022 12:07
@kw217
Copy link
Collaborator Author

kw217 commented Mar 4, 2022

Sorry it looks like it all changed - I spotted it had mostly DOS line endings! Fixed to Unix now.

Copy link
Contributor

@angusi angusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two minor comments.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Signed-off-by: Keith Wansbrough <Keith.Wansbrough@metaswitch.com>
@kw217 kw217 merged commit a21c66f into master Mar 4, 2022
@kw217 kw217 deleted the update-contributing-instructions branch March 4, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants