-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow entrypoints by default #312
Conversation
1dcc25d
to
8c58fea
Compare
LGTM but would like a review from Richard as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me. I'm not 100% what is the least surprise to people - I think most users, for whatever reason, think floki is some magic thing which always gives you an interactive session in any docker container (hence entrypoint suppression, and shell as the default entrypoint - to the first approximation the thing most likely to achieve this).
Equally, most containers don't have weird entrypoints that need supressing (especially the ones floki is used with). For those that do, having the override is important. It's probably more reasonable that most containers behave as they normally do, so entrypoint override by default I suppose is a default created by the rare case, so more suprising. I don't know.
Anyway, happy with the change - one small thing on the default shell (which to be honest was probably as you've written for ages already anyway).
Signed-off-by: Andy Caldwell <andycaldwell@microsoft.com>
I've deprecated the |
Signed-off-by: Andy Caldwell <andycaldwell@microsoft.com>
Signed-off-by: Andy Caldwell <andycaldwell@microsoft.com>
Signed-off-by: Andy Caldwell <andycaldwell@microsoft.com>
ed6e431
to
8e3a2e3
Compare
Why this change?
Following the principle of least surprise, don't suppress image entrypoints unless asked to.
Relevant testing
Tested with an image that runs an entrypoint before starting the image.
Checks
These aren't hard requirements, just guidelines
cargo fmt
README.md
updated for this change, if necessaryCHANGELOG.md
updated for this change