Use Rusoto client to allow connecting to non-AWS S3 instances #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bossmc
force-pushed
the
rusoto-client-for-aws
branch
from
6cb3b26
to
0d03978
Compare
|
@richardwhiuk can you please give this a once over before I upstream it? Thanks! |
| // or make those builders put their credentials in ~/.aws/credentials | ||
| ProfileProvider::with_configuration(home.join(".boto"), "Credentials"), | ||
| ]; | ||
| let provider = AutoRefreshingProvider::new(ChainProvider::with_profile_providers(profile_providers)); |
There was a problem hiding this comment.
It's not obvious to me why getting rid of the above code is OK.
bossmc
force-pushed
the
rusoto-client-for-aws
branch
from
0d03978
to
7fad391
Compare
Previously we would lock to prevent multiple toolchain creations at once, but the lock was acquired after checking for the presence of the toolchain in question and determining it wasn't present. In case multiple attempts were made to create a toolchain asynchronously the attempts would serialize on this lock but still redundantly re-create toolchains.
…cheduler. Fixes mozilla#513. We've found some situations where a server will retain jobs waiting for a client to request they be run. In practice this means that a client that's having trouble connecting to a server (due to mozilla#516 or another issue) can take that server offline by consuming its capacity, which will be unavailable indefinitely as far as the scheduler is concerned. This commit takes the step of tracking jobs that have been assigned but have not yet been started. When receiving a heartbeat from a server, the scheduler will check the unclaimed jobs assigned to that server and de-allocate any that have been waiting to start for too long. The threshold for now is 1 minute for jobs that start in the "Ready" state and 5 minutes for jobs in the "Pending" state in case toolchain packaging and transfer overrruns the smaller threshold.
bossmc
force-pushed
the
rusoto-client-for-aws
branch
from
3a671ab
to
60ebcec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move off the inline S3 client implementation to using rusoto. Mainly to support authentication above version 2 (e.g. for minio integration). The configuration API is unchanged so this should be a non-breaking change.