Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Globals in CXXNaiveIcoCodeGen #1028

Closed
Stagno opened this issue Oct 2, 2020 · 0 comments · Fixed by #1039
Closed

Globals in CXXNaiveIcoCodeGen #1028

Stagno opened this issue Oct 2, 2020 · 0 comments · Fixed by #1039
Assignees
@mroethlin
Labels
backend dawn related enhancement

Comments

@Stagno
Copy link
Contributor

Stagno commented Oct 2, 2020

Support for globals is still not enabled in CXXNaiveIcoCodeGen, see:

dawn/dawn/src/dawn/CodeGen/CXXNaive-ico/CXXNaiveCodeGen.cpp

Lines 382 to 385 in aa257ec

// stencilClassCtr.addInit("m_dom(dom_)");
// if(!globalsMap.empty()) {
// stencilClassCtr.addArg("m_globals(globals_)");
// }

Not sure if uncommenting these (and other lines in generateStencilClasses()) enables support for globals right away.
(thanks to Joerg Behrens for reporting this)
@Stagno Stagno added enhancement backend dawn related labels Oct 2, 2020
@mroethlin mroethlin mentioned this issue Oct 13, 2020
Merged
mroethlin added a commit that referenced this issue Oct 16, 2020
@mroethlin
Enabling Globals for Unstructured Backends (#1039)
713801a 
## Technical Description

This PR enables globals for the unstructured backends. Furthermore, an unreported issue where globals were not propagated from the wrapper class to the stencil class was fixed. Additionally, a bug in the unstructured cuda codegen was fixed when translating stencils that only use dense dimensions.

### Resolves / Enhances

Fixes #1030
Fixes #1028

### Notes

The methods to set and get globals in the cuda backend are on the inner stencils. This will be addressed in [this issue](#1038). Also, a method to communicate globals from FORTRAN will need to be devised (not addressed yet). 

### Testing

New tests in dawn4py and a new unstructured integration test to test the correct operation of the `CXXNaiveIco` backend. `CudaIco` backend tested manually. 

### Dependencies

This PR is independent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mroethlin mroethlin

Labels
backend dawn related enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enabling Globals for Unstructured Backends mroethlin/dawn
2 participants
@Stagno @mroethlin