Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-format pollution #253

Closed
Stagno opened this issue Aug 27, 2019 · 3 comments
Closed

clang-format pollution #253

Stagno opened this issue Aug 27, 2019 · 3 comments

Comments

@Stagno
Copy link
Contributor

Stagno commented Aug 27, 2019

Current master and open PRs are not clang-formatted due to non-uniform ways used to edit the code (I sometimes used search and replace on the whole code for example and forgot to run clang-format afterwards).
A possible solution is to add to scripts/jenkins/build.sh a check of whether the code just cloned is correctly formatted. It should run clang-format on the cloned source and git diff it w.r.t. the remote source.

@havogt
Copy link
Contributor

havogt commented Sep 3, 2019

We have a precommit hook in gridtools which checks formatting. We could copy it.

@Stagno
Copy link
Contributor Author

Stagno commented Sep 6, 2019

We have a precommit hook in gridtools which checks formatting. We could copy it.

Seems like a good idea! Should we do it just after the current big PRs are merged?

@Stagno
Copy link
Contributor Author

Stagno commented Oct 9, 2019

solved by #299

@Stagno Stagno closed this as completed Oct 9, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants