-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfixes psy2dawn #1157
Open
mroethlin
wants to merge
25
commits into
MeteoSwiss-APN:master
Choose a base branch
from
mroethlin:hotfixes_psy2dawn
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Hotfixes psy2dawn #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
launch jenkins |
1 similar comment
launch jenkins |
launch jenkins |
…_psy2dawn Conflicts: dawn/test/integration-test/dawn4py-tests/data/generate_versioned_field_ref.cpp
launch jenkins |
launch jenkins |
…gen. breaks naive cpp bindgen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Description
This PR contains some hot fixes for the Psy2Dawn Project. This should probably be 3 PRs but since this project is EOL I deemed it acceptable to have a summary PR for this
Resolves / Enhances
checkOffset
function in generated codestatic
for easier linking of multiple stencils into one libraryGRIDTOOLS_DAWN_HALO_EXTENT=0
Example
A simple iteration space
would lead to false positive testing against the iteration space along the j domain in a test case found during the psy2dawn deliverable.
In the cuda backend, a sequence like
would be spuriously compiled to the equivalent of
Testing
Dependencies
This PR is independent.