Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use experimental::fs if fs is not supported #640

Merged

Conversation

havogt
Copy link
Contributor

@havogt havogt commented Jan 22, 2020

Technical Description

Use std::experimental::filesystem if std::filesystem is not supported, i.e. gcc < 8.

@havogt
Copy link
Contributor Author

havogt commented Jan 22, 2020

launch jenkins

@havogt havogt requested a review from jdahm January 22, 2020 08:02
Copy link
Contributor

@jdahm jdahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! __has_include() seems to be part of the standard now, and is included in at least GCC and LLVM. At some point when we have Travis testing, we should try to exercise this code.

@havogt havogt merged commit 55046c4 into MeteoSwiss-APN:master Jan 23, 2020
mroethlin pushed a commit to mroethlin/dawn that referenced this pull request Jan 23, 2020
## Technical Description

Use std::experimental::filesystem if std::filesystem is not supported, i.e. gcc < 8.
mroethlin pushed a commit to mroethlin/dawn that referenced this pull request Mar 3, 2020
## Technical Description

Use std::experimental::filesystem if std::filesystem is not supported, i.e. gcc < 8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants