Meteor AutoForm 7.1.0 - Autocomplete #1701
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4Z4T4R
commented
Dec 29, 2020
4Z4T4R
commented
- Added new inputTypes autocomplete directory
- Added HTML for Autocomplete Template
- Added JS for Autocomplete Template
- Circular selection allows arrows to cycle tip to tail and vice versa
- Reactive options allow Tracker vars to provide labels and values to dropdown selections
- Simpl-Schema defined options provide the same path to values and labels as select lists.
- Navigable via arrows so your mouse can rest.
- No third party solutions so we're not feeling bloated.
- Uses bootstrap 4 dropdown class definitions for style so adopters can use theme packages, no problemo.
- Conforms to StandardJS delinting and format so that the gods (and developers) are happy.
- Added new inputTypes autocomplete directory - Added HTML for Autocomplete Template - Added JS for Autocomplete Template (WIP: Need actions!) - Styles will go inside `meteor-autoform-themes` project
- Circular selection - Reactive options - Simpl-Schema defined options - Navigable via arrows - No third party solutions
- Uses bootstrap 4 dropdown class definitions for style - Conforms to StandardJS delinting and format
jankapunkt
reviewed
Dec 29, 2020
|
|
||
| // choose an answer on click | ||
| $suggestions.children().click((e) => { | ||
| const dataValue = $(e.target).attr('data-value') |
There was a problem hiding this comment.
can you please change this to
const dataValue = me.$(e.target).attr('data-value')so it uses the local-scoped jQuery selector plus it resolves the linter error.
- added hidden input field to allow labels and values in autocomplete; think 'Full Name' and 'UserId' - now adjusting context for visible and hidden inputs, so AutoForm works as expected on submit - run lint passed - run test passed
- Escape closes the dropdown - Double-click opens the dropdown - Removed a lone helpers definition of no value - Preserved sort order of backing object array - Form /should/ submit properly when 'Enter' triggers and dropdown is hidden - Maybe we're all clear for launch, but I'm not counting my chickens yet
- Fixed HTML structure to display bootstrap validation errors properly in autocomplete inputs.
- Now the values between the hidden and visible fields remain identical so that validation works correctly if the value is deleted.
- Now, after selecting from the autocomplete options, the field keeps focus so that one may tab to the next field.
4Z4T4R
commented
Jan 23, 2021
| @@ -230,4 +230,9 @@ Template.afAutocomplete.onRendered(function () { | |||
| $input.dblclick((e) => { | |||
| callback(e) | |||
| }) | |||
|
|
|||
| // show on double click | |||
There was a problem hiding this comment.
change comment to show on touch
Good catch!
Comment on lines
125
to
129
| const updateValue = value => { | ||
| $hidden.val(value) | ||
| $hidden.trigger('change') | ||
| } | ||
|
|
There was a problem hiding this comment.
Clever! Nicely done. Is it safe to assume that the change event triggers validation? on blur too?
There was a problem hiding this comment.
The change is used to fire Updates for any reactive getter like AutoForm.getFieldValue
While blur triggers validation.
…lid (in selectOptons) value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.