Fixed prototypal inheritance and avoid double-wrapping #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once we have set up CI I will review this one |
|
@jankapunkt @SimonSimCity tests were merged, so we can proceed with this now. |
|
@SimonSimCity I have taken the liberty to adjust things to align more with the modern infrastructure. Can you please take a look to make sure that it works as you intended? |
|
@StorytellerCZ tests fail with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally makes this library compatible with hwillson/meteor-stub-collections.
The reason why it fails is that the properties of the prototype change if
Mongo. _CollectionPrototypewas not set before loading this library - which for some reason always happens before loading the tests ... So I was not able to fully prove this by a test, but can confirm that it works now.