dont run getDocs in update or r remove hooks if no aspects are defined

Meteor-Community-Packages · May 8, 2014 · f1d2ac6 · f1d2ac6
1 parent 0ae1f0f
commit f1d2ac6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/remove.js b/remove.js
@@ -9,7 +9,9 @@ CollectionHooks.defineAdvice("remove", function (userId, _super, aspects, getTra
   // args[0] : selector
   // args[1] : callback
 
-  var docs = CollectionHooks.getDocs.call(self, collection, args[0]).fetch();
+  if (aspects.before || aspects.after) {
+    docs = CollectionHooks.getDocs.call(self, collection, args[0]).fetch();
+  }
 
   // copy originals for convenience for the "after" pointcut
   if (aspects.after) {

diff --git a/update.js b/update.js
@@ -16,9 +16,11 @@ CollectionHooks.defineAdvice("update", function (userId, _super, aspects, getTra
     args[2] = {};
   }
 
-  fields = getFields(args[1]);
-  docs = CollectionHooks.getDocs.call(self, collection, args[0], args[2]).fetch();
-  docIds = _.map(docs, function (doc) { return doc._id; });
+  if (aspects.before || aspects.after) {
+    fields = getFields(args[1]);
+    docs = CollectionHooks.getDocs.call(self, collection, args[0], args[2]).fetch();
+    docIds = _.map(docs, function (doc) { return doc._id; });
+  }
 
   // copy originals for convenience for the "after" pointcut
   if (aspects.after) {