Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated tests #176

Merged
merged 18 commits into from Jan 16, 2024
Merged

Migrated tests #176

merged 18 commits into from Jan 16, 2024

Conversation

manueltimita
Copy link
Contributor

@manueltimita manueltimita commented Jan 15, 2024

Migrated tests so they are compatible with async/await. Note that some are still failing, due to issue #175

manueltimita and others added 16 commits December 7, 2023 12:22
Track when all initial documents have been processed by the added callback
Wait for all publications to finish processing initial added callbacks before calling this.ready()
Minor linting fix - extra semicolon
- Fix automatic lint
- Changelog addition
Promise executor functions should not be async. (no-async-promise-executor)
linting fixes
Fixes this.ready() being fired too early
Migrated tests so they are compatible with async/await. Note that some are still failing, due to to issue #175
@manueltimita
Copy link
Contributor Author

manueltimita commented Jan 15, 2024

I think I messed this one up. Should have opened a separate a branch for commit a6ce2d7. It fixes #175. Happy to redo all this if needed

@manueltimita manueltimita mentioned this pull request Jan 15, 2024
@StorytellerCZ
Copy link
Member

Let's merge this into #173

@StorytellerCZ StorytellerCZ changed the base branch from master to feature/update-tests January 15, 2024 09:11
@StorytellerCZ StorytellerCZ merged commit 0355d45 into Meteor-Community-Packages:feature/update-tests Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants