Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An example with Iron-Router #16

Closed
ouuyeah opened this issue Oct 4, 2013 · 5 comments
Closed

An example with Iron-Router #16

ouuyeah opened this issue Oct 4, 2013 · 5 comments

Comments

@ouuyeah
Copy link

ouuyeah commented Oct 4, 2013

Please make an example with Iron-Router, thanks you very much.

@alanning
Copy link
Contributor

alanning commented Oct 5, 2013

Got a basic Iron-Router example going but it has some rough edges that I don't know how to fix.

https://github.com/alanning/meteor-roles/tree/iron-router

A lot of unknowns:

  • how to set a layout in a before filter
  • how to compose multiple filters
  • why does notFoundTemplate in Router.configure not handle 404s
  • why is Loading template continually displayed after login

Feel free to jump in and play around. Be sure to submit pull requests when you figure something out!

@alanning
Copy link
Contributor

alanning commented Oct 5, 2013

Well fixed the Loading template issue at least by using this.render('foo') rather than this.template = foo.

@alanning
Copy link
Contributor

alanning commented Oct 5, 2013

merged into master branch. still has rough edges but works.

@alanning alanning closed this as completed Oct 5, 2013
@tony-kerz
Copy link

hey adrian,

thanks for the iron-router example, i'm trying to work thru that now.

with the disclosure that i'm not a JS expert, one thing that i wanted to ask about was this line:

https://github.com/alanning/meteor-roles/blob/master/examples/iron-router/client/routing.js#L85

the iron-router doc shows only a layoutTemplate option vs a layout option, should this be layoutTemplate here?

regards,
tony

@alanning
Copy link
Contributor

Hi Tony,

Thanks for the email. Actually I think that is a change to the iron-router
api so this example probably needs to be updated. I wrote it a while ago
and iron-router has evolved quite a bit since then. (A good thing.)
That's actually why I have't publicized the example in the readme yet.

If you have time to get the example working with the latest iron-router, I
would love a pull request. :-)

Cheers,
Adrian

On Thu, Dec 19, 2013 at 11:19 AM, tony kerz notifications@github.comwrote:

hey adrian,

thanks for the iron-router example, i'm trying to work thru that now.

with the disclosure that i'm not a JS expert, one thing that i wanted to
ask about was this line:

https://github.com/alanning/meteor-roles/blob/master/examples/iron-router/client/routing.js#L85

the iron-router doc shows only a layoutTemplate option vs a layoutoption, should this be
layoutTemplate here?

regards,
tony


Reply to this email directly or view it on GitHubhttps://github.com//issues/16#issuecomment-30942000
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants