New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4 #379
base: master
Are you sure you want to change the base?
Version 4 #379
Conversation
…feature/export-collections
And account for the new index creation method
@StorytellerCZ is there anything that isn't already implemented by the latest release that contains the async counterparts? |
Not 100% sure, but I think we have everything. I will remove the sync MongoDB calls in this branch. Or maybe for the client we can leave the sync methods? Thoughts? |
@StorytellerCZ I think it would make sense to leave sync methods for the client. This is consistent with other packages like Accounts isn't it ? Thanks |
Synchronous Mongo calls on the client side are alright in Meteor 3.0, IIRC. When is this PR expected to be merged in and published? I would love to test this in my application. |
Once this is merged: I will release a beta. |
I would suggest updating the
For obvious reasons, the method needs to become async to be able to count how many records are in the collection. |
@dallman2 PRs welcome. |
Published alanning:roles@4.0.0-alpha.1, please take things out for a spin. It is Meteor 3.0-beta.7 compatible! |
…-collections Export collections for direct access
console.debug
for debugging messagesRolesCollection
andRoleAssignmentsCollection
can now be exported in addition to being accessed viaMeteor.roles
andMeteor.roleAssignment