resolves #59 and adds more precise expressions #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nemo64
changed the title
Nemo64
changed the title
|
Btw. There seems to be a invalid |
|
Weird, I have no memory of ever making or committing such a change and the travis tests have always passed just fine. I'll fix it. |
aldeed
added a commit
that referenced
this pull request
May 13, 2014
resolves #59 and adds more precise expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took it in my hand and created more precise expressions for EMail and added domain and IP (because they are all related). To be sure I added tests for the expressions.