rebase #1
Merged
rebase #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #8590 - Scale image larger within the dimensions. - Apply a minimum dimension of 1024.
This reverts commit 8aa1850.
Exception logging tends to be race-y, so now we block and wait for all logs to be written before continuing with the crash.
Some devices have a limit of 100 unique JobScheduler jobs. Previously we allowed up to 1,000. Given that we just need _some_ job running, I lowered the limit to 75 to give us some head room.
The new JobManager stuff created a table that had an auto-incrementing ID, which was incorrectly being backed up and restored, causing a crash. Now we skip it on both import and export.
It used to be that we let Android do the default behavior of full-screening the EditText when in landscape, but honestly I don't know who prefers that. So I've turned it off. Fixes #8769
This allows you to take a photo, then choose the recipients after. This also makes it so we only upload the attachment once.
On phones with no SIM card, if you manage to enqueue a job with a CellServiceConstraint, the previous check we were using to check if there was cell service could hang indefinitely on some devices. This changes it to a fast check, which all constraints should be.
Send support isn't enabled yet, but didn't want to forget about it.
Prevents crash loop in #8910
Only affects people who have force-enabled revealable messages and then gone back to a build that doesn't have it enabled.
The crash happened because #getNextClosestEvent was called when mmsDatabase was null, which would normally be impossible. However, it seems implied that somehow #getNextClosestEvent was being called in the parent constructor before the child class was fully initialized. That would imply that the looper was called synchronously in some freak scenario, but it's the only explanation. So I added a delay to the call in the parent constructor. ```java java.lang.NullPointerException: at org.thoughtcrime.securesms.revealable.RevealableMessageManager.getNextClosestEvent (RevealableMessageManager.java:40) at org.thoughtcrime.securesms.revealable.RevealableMessageManager.getNextClosestEvent (RevealableMessageManager.java:23) at org.thoughtcrime.securesms.service.TimedEventManager.lambda$scheduleIfNecessary$1 (TimedEventManager.java:44) at org.thoughtcrime.securesms.service.-$$Lambda$TimedEventManager$kZDO3F2WBQVtGx-SkAgEDt8jCeU.run (Unknown Source:2) at android.os.Handler.handleCallback (Handler.java:873) at android.os.Handler.dispatchMessage (Handler.java:99) at android.os.Looper.loop (Looper.java:193) at android.os.HandlerThread.run (HandlerThread.java:65) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.