Fix potential buffer overrun when node_name calls stoupper

[jsberg-bnl]

name is a Fortran string and is not null terminated.
stoupper searches for the null termination.
Replace stoupper call by running toupper over the length of the Fortran string.

[rdemaria]

Thanks! Do you have a case in which the buffer overrun happens?

[jsberg-bnl]

I do, though I haven't chased down what specifically triggered it. The sanitizer caught it when I was chasing down a different bug. I can upload a zip file on Monday if you like, though it is a rather large lattice.

[rdemaria]

Don't bother. It was just to understand if there were other traps like this lurking around.

[jsberg-bnl]

I would definitely be on the lookout for things like this. The C/Fortran mixing as done here is not particularly robust, in particular when it comes to string handling (e.g., you'll notice that a lot of calls with string literals have an extra space at the end of the string; that is there to address this sort of issue, and you just need to know "when you make this call, append an extra space."). I didn't do a complete review of all the stoupper calls, but I glanced at a couple of other occurrences, and they were using C strings and so should be fine, but it would probably be worth checking them all. Running the test suite with the sanitize flags (and maybe GC off) might be enlightening.