Ensure that exact_model is set before zero_key is called #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zero_key(key) sets key%exact equal to the value of exact_model
In the previous code, zero_key was called before exact_model was set,
and so key%exact was set based on node_value("exact ") of the previous node.
So, move the code to set exact_model to before zero_key is called.
rdemaria
added
the
bug
rdemaria
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zero_key(key) sets key%exact equal to the value of exact_model
In the previous code, zero_key was called before exact_model was set,
and so key%exact was set based on node_value("exact ") of the previous node.
So, move the code to set exact_model to before zero_key is called.
Fixes #1110