Make track/twiss able to treat a thick solenoid exactly #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 15, 2022 16:42
Used only when the EXACT flag is set for TWISS Probably not complete for a nonzero XTILT (undocumented parameter)
No attempt to make xtilt exact; would be possible with some refactoring
Updated original test-thick-solenoid test with new results Note original time calculation for the thick case was particularly bad Updated test-twiss-17
|
Also, I don't change the |
|
And I make no attempt to fix the two |
rdemaria
approved these changes
Aug 15, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
twiss, uses theexactflag totwissto choose between the original algorithm and the exact calculation. Switchtrackto using the exact calculation. Fortrack, the original time of flight computation is significantly improved for the case intest-thick-solenoid(compare the thin and thick results).twissdoes everything through second order. Created a new test case comparing toptc_twissresults. Radiation calculations should be nearly unchanged (only differences should be related to using the exactly computed longitudinal momentum), I did not attempt to add radiation in the solenoid body.