Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to throw fatal error when missing file in interactive mode. #1144

Merged

Conversation

tpersson
Copy link
Contributor

A missing file caused a problem in the upload of an optics. This was not spotted since JMAD runs in interactive mode and calling a missing file only triggers a warning. This PR adds a flag to make this fatal also in interactive mode. The default behaviour is as in the past.

@rdemaria
Copy link
Contributor

Any reason not to make the flag also valid for non-interactive mode?

@tpersson
Copy link
Contributor Author

For the non-interactive mode, the behaviour is always to exit which I think is fine. If one would change the default behaviour so that the interactive exits by default then having the flag effecting both would make sense but I didn't want to change the default behaviour based on my experience with all the complaints we receive when we do...

@rdemaria
Copy link
Contributor

ok!

@rdemaria
Copy link
Contributor

In general for interactive work, I always use no_fatal_stop because it is common to make mistakes or try things out without being afraid of restarting from scratch.

@tpersson
Copy link
Contributor Author

Yeah, indeed this is basically doing the opposite. It is really for the cases where it is not really interactive. It is for things such as JMAD and also the beta-beat.src where we still have a parser that opens a MAD-X in a stream.

@tpersson tpersson merged commit 7a287f4 into MethodicalAcceleratorDesign:master Sep 27, 2022
@tpersson tpersson deleted the fatalInteractive branch September 27, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants