Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with ESAVE after using FILL_KNOB #1150

Conversation

tpersson
Copy link
Contributor

@tpersson tpersson commented Nov 16, 2022

This fixes the issue reported in #1149 from @fsoubelet. However, it would be good if someone else checked if this has some unwanted side effects.. I haven't noticed any but there is definitely a risk there is..

@rdemaria
Copy link
Contributor

After discussing with @ldeniau:

current_node = NULL was added to fix another bug

The issue is that

augment_count

is used in

pro_error_make_efield_table

and if t->p_nodes is not null, then it relies on current_node to be meaningful.

@tpersson
Copy link
Contributor Author

I think this is all good right? Should we merge?

@rdemaria
Copy link
Contributor

ok for me!

@rdemaria rdemaria merged commit 1a6b3b7 into MethodicalAcceleratorDesign:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants