Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Se_status.f90 #1220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Se_status.f90 #1220

wants to merge 1 commit into from

Conversation

rdemaria
Copy link
Contributor

Fix an off bound error that show using openmp. @piotrskowronski could you verify?

Fix an off bound error that show using openmp. @piotrskowronski could you verify?
@ldeniau
Copy link
Contributor

ldeniau commented Mar 27, 2024

The fix looks ok to me as the polygon is closed with POLYGN points when allocated in Sn_mad_like.f90.
Apart from small details, it's the same code (after fixing the bound) as mine in MAD-NG (written 5 years ago):
https://github.com/MethodicalAcceleratorDesign/MAD-NG/blob/0d1749f893ef52f932cb24379fb7800743607831/src/mad_poly.c#L37
I found a nice ref with a C implementation at http://geomalgorithms.com/a03-_inclusion.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants