Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make thin for k0=0 when angle is defined #666

Merged
merged 2 commits into from Aug 31, 2018
Merged

Fix make thin for k0=0 when angle is defined #666

merged 2 commits into from Aug 31, 2018

Conversation

tpersson
Copy link
Contributor

This closes #665

tobias added 2 commits August 29, 2018 14:24
This fixes the problem with k0=0.
f23da10 
Two tests still fails. The new output from makethin is better but not numerical identical to the old.
This fixes the makethin when k0=0.
8e3fb6b
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0002%) to 53.708% when pulling 8e3fb6b on tpersson:fixMakeThin into 5faaf3e on MethodicalAcceleratorDesign:master.

madcern
madcern approved these changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@madcern madcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was checked with Helmuth and it was fine with him.

@madcern madcern merged commit 50c6728 into MethodicalAcceleratorDesign:master Aug 31, 2018
@tpersson tpersson mentioned this pull request Sep 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madcern madcern madcern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tpersson @coveralls @madcern