Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents aperture moduel to run with wrong setting of twiss #667

Conversation

tpersson
Copy link
Contributor

@tpersson tpersson commented Sep 5, 2018

This PR fixes the issue that aperture gave wrong results with twiss, center. It is now a forbidden setting and mad-x do not output any aperture if this is chosen. The special case where there are only thin aperture object is accepted since the problem is creating the extra nodes needed for the extra slices.

@tpersson
Copy link
Contributor Author

tpersson commented Sep 5, 2018

This fixes the issue reported in #603

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 53.711% when pulling 39842ce on tpersson:addErrorForCenterTwissOption into 50c6728 on MethodicalAcceleratorDesign:master.

@madcern madcern merged commit 3676950 into MethodicalAcceleratorDesign:master Sep 5, 2018
@tpersson tpersson deleted the addErrorForCenterTwissOption branch September 17, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants