Condtionally set property in VSTeamBuildDefinitionProcessPhase #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 3, 2019 13:20
VSTeamBuildDefinitionProcessPhase
- Second phase that does not have condition property.
|
Reviewing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSTeamBuildDefinitionProcessPhase
PR Summary
Fix for an issue where the
conditionproperty is not being set under Azure DevOps server under some circumstances (old builds, or possibly something to do with the update from TFS2018 to AzD, didn't investigate further after hitting the error). This causes an error when creating aVSTeamBuildDefinitionProcessPhaseobject. This PR makes the assignment of the variable conditional, which avoids the error.PR Checklist
Not sure if a simple bug fix warrants mentioning in the Changelog, there's certainly no need to update the help and the psd1 also keeps unchanged. The test data was adapted