Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Get-VSTeamWiql #314 #315

Closed
wants to merge 5 commits into from
Closed

Fix Get-VSTeamWiql #314 #315

wants to merge 5 commits into from

Conversation

jhoneill
Copy link
Contributor

PR Summary

Fix issues described in #314

PR Checklist

  • [ ] [Write Help]
    No functional change
  • [ ] [Write Unit Test]
    Existing unit test should work
  • [Update CHANGELOG.md]
    Yes

@SebastianSchuetze
Copy link
Collaborator

SebastianSchuetze commented May 15, 2020

Your PR builds are not running as I mention in the other one. Due to a wrong change you did:

jhoneill@9feee71#diff-a9c43fc4a14707ca2c3bb16664e4031f

you changed the property outputFile to "vsteam.psm1" not sure why you did it, but that is the wrong place. ;-)

Please run the build script locally before committing, you would have caught it like I did. :-)

image

@@ -1,5 +1,5 @@
{
"outputFile": "vsteam.classes.ps1",
"outputFile": "vsteam.psm1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will not be merged. I will get other changes in.

@DarqueWarrior
Copy link
Collaborator

I made some changes but could not push to this PR so I will close and merge from a different branch.

To https://github.com/jhoneill/vsteam
 ! [remote rejected] pr/jhoneill/315 -> pr/jhoneill/315 (permission denied)
error: failed to push some refs to 'https://github.com/jhoneill/vsteam'

@DarqueWarrior DarqueWarrior mentioned this pull request May 24, 2020
3 tasks
@SebastianSchuetze SebastianSchuetze mentioned this pull request Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants