Fix #493 import-module loses previously stored configuration #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user calls Set-VSTeamAccount with -Local parameter, the TEAM_VERSION environment variable is preserved. The Versions.SetApiVersion did not manage the APIs.Version value and the test failed. This behavior does not occur in during the github build because the TEAM_VERSION variable is not set
mnieto
changed the title
|
@SebastianSchuetze , any chance to merge this PR? |
SebastianSchuetze
requested changes
May 11, 2023
SebastianSchuetze
approved these changes
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This fix #493 issue
When the module is configured with Set-VSTeamAccount -Level user, the configuration is stored in env variables and then recovered next time while import-module vsteam
The problem was introduced in commit 0528c76 (#467 closed in #480)
Also fixed a related problem with test ran in local: If the user calls Set-VSTeamAccount with -Local parameter, the TEAM_VERSION environment variable is preserved in the user's profile. The Versions.SetApiVersion did not manage the APIs.Version value and the test failed. This behaviour does not occur in during the GitHub build because the TEAM_VERSION variable is not set (it gets the default value).
PR Checklist