Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify date/time format and make it cultureInfo independent #524

Merged
merged 2 commits into from
May 14, 2023

Conversation

mnieto
Copy link
Contributor

@mnieto mnieto commented May 14, 2023

PR Summary

Fix #511
Date format in .github/moduleMessages.json is different than test/sampleFiles/moduleMessages.json
Also the [DateTime]::Parse can throw execption depending on the current locale.

This change unifies the date format in _showModuleLoadingMessages function using ParseExact instead Parse

The field toDate in moduleMessages.json should have dd/MM/yyyy HH:mm:ss format

PR Checklist

@SebastianSchuetze
Copy link
Collaborator

Thanks for the fix!

@SebastianSchuetze SebastianSchuetze merged commit a5e282b into MethodsAndPractices:trunk May 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error during module import due to invalid message date
2 participants