Optionally reset Semantic.UI -webkit-scrollbar styles #27
Comments
@TheDolo |
@TheDolo @PharrellWANG Thanks for the report, I'll check this issue later, currently working on advanced images preprocessing. |
I figured out that it's not a right/bottom margin - it's a scrollbar, created by UPD1: Looks like the issue was caused by Semantic-UI latest version. They moved from normalize.css 3.0.1 to normalize.css 7.0.0. UPD2: Just found the problem: in Semantic.UI@2.2.11(July 11) was added: body ::-webkit-scrollbar {
width: 10px;
} So by default size of the scrollbar is 10px. body ::-webkit-scrollbar {
width: 0px;
} |
Heh, this removes the scroll bar for me lol! The bottom margin is still visible with the above too. |
Just change in export const SidebarSemanticPusherStyled = styled(Sidebar.Pusher)`
height: 100%;
overflow: scroll!important;
-webkit-overflow-scrolling: touch; to: export const SidebarSemanticPusherStyled = styled(Sidebar.Pusher)`
height: 100%;
overflow-y: scroll!important;
-webkit-overflow-scrolling: touch; This fixes will be in the next minor version, sorry for no updates for so long |
This fixes the bottom bar for me, however the right bar still does not auto hide (like the demo), and has a background color that is different from the rest of the page (part of the auto hide problem, like in the pictures above). Thank you! |
did you insert code from this comment into your styles? |
The scrollbar is no longer visible when scrolling across the entire app for all components when I insert that into global.jsx, but the background color is gone. I also tested on a fresh clone, same result. |
It's because some semantic's style still aren't reseted. Will be fixed too |
@TheDolo probably fixed in 364fa41 |
:( I have no scrollbar on both dev and build, but I can still scroll. I don't get why your online demo is fine! Shift refresh doesn't help. I dug up these up though! https://github.com/Semantic-Org/Semantic-UI-React/blob/master/docs/app/Components/DocsLayout.js#L55 https://github.com/Semantic-Org/Semantic-UI-React/blob/master/docs/app/Components/Sidebar/Sidebar.js Edit: No scrollbar on demo site too, sometimes. yea something is up with refresh/resetting ugh. |
@TheDolo, sorry can investigate your issue only in next 45 minutes :( |
Doesn't need to be today! It probably affects everyone using this boilerplate, I'd be grateful for any fix any time you can for this one! Edit: *I said sidebar, I mean't the right body scrollbar is missing with this code (but I understand why you do this line!)
|
@TheDolo oh, I've just understood that you meant scrollbar, I didn't understand how sidebar can disappear from the page :)
|
Hi @TheDolo @PharrellWANG |
Looks like scrollbar styles were removed from SUI core |
Boom! This thread just saved my butt. |
I'm submitting a ...
Bug Report:
Bottom and right margin in built version vs demo version online.
What is the expected behavior?
Margins like the demo.
What is the current behavior?
Steps to reproduce:
Git clone, npm install, npm run dev
Useful Info:
Your environment:
Other information
Thank you :) I've been using this boilerplate extensively, just the perfect balance of not too much and just enough :)
The text was updated successfully, but these errors were encountered: