Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist SSO Auth #255

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Persist SSO Auth #255

merged 2 commits into from
Jun 24, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Jun 20, 2024

Currently when configured for SSO, the app does not persist keycloak auth when the page is refreshed, across tabs, or when navigating to a URL directly. This is because a react-oidc-context provider configuration is missing. In addition, there are a few other updates required to ensure auth isn't loading during checks. This PR includes updates for that config as well as the updates to the UI to handle loading.

Description

  • Updated keycloak config with userStore param to support persisted auth
  • Updated components to check if auth is loading before returning auth state
  • Updated redirect uri to dashboard

Related Issue

Motivation and Context

  • Provides a better user experience, allowing opening new tabs and opening directly URL

How Has This Been Tested?

  • Tested with local keycloak

Screenshots (if appropriate):

N/A

@jbouder jbouder marked this pull request as ready for review June 24, 2024 12:59
@jbouder jbouder merged commit 87ab05b into main Jun 24, 2024
5 checks passed
@jbouder jbouder deleted the persist-auth branch June 24, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants