Contentando a Codacy Parte 2

Metronus · Apr 24, 2017 · 0f8050c · 0f8050c
1 parent 247072c
commit 0f8050c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/Metronus-Project/metronus_app/templatetags/custom_tags.py b/Metronus-Project/metronus_app/templatetags/custom_tags.py
@@ -56,20 +56,14 @@ def is_weekend(day, month, year):
 
 @register.assignment_tag
 def is_admin(actor):
-    if actor.user_type == 'A':
-        return True
-    else:
-        return False
+    return actor.user_type == 'A'
 
 
 @register.assignment_tag
 def has_role(actor):
     if actor.user_type == 'E' or actor.user_type == 'A':
         try:
-            if ProjectDepartmentEmployeeRole.objects.filter(employee_id=actor.id).count() > 0:
-                return True
-            else:
-                return False
+            return ProjectDepartmentEmployeeRole.objects.filter(employee_id=actor.id).count() > 0
         except:
             return False
     else:

diff --git a/Metronus-Project/metronus_app/test/testProjectMetrics.py b/Metronus-Project/metronus_app/test/testProjectMetrics.py
@@ -367,7 +367,7 @@ def create_task_in_projdept(project, department):
 
         n_dep = len(departments)
         # Do the random test 5 times
-        for k in range(5):
+        for _ in range(5):
             Task.objects.all().delete()
 
             tasks_per_dpmt = [random.choice(range(11)) for _ in range(n_dep)]