Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restriction splicing - remove restricted #568

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

Filip-Macecek
Copy link
Contributor

@Filip-Macecek Filip-Macecek commented Mar 8, 2024

Summary

Remove "Restricted!" from Restrictions/set and Restrictions/clear, as these were moved to general availability

Follow style guide

Style guide

Check during review

  • The changelog and potentially a deprecation entries are in place.
    • The changelog timestamp is date of merge to develop.
  • JSON example extended.
    • New properties are added to the correct place in the JSON.
  • New properties in the table are added to the correct place.
  • Correct formatting:
    • Spacing is consistent between titles, sections, tables, ...
    • Correct JSON format - indentation.
  • DateTime properties should always be defined in ISO format.

Copy link
Contributor

@MikeAdamsMews MikeAdamsMews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Filip-Macecek, I'm trying to clear the backlog of PRs on the docs. It's nice to see that these operations are no longer restricted, can you also remove the Restricted! labels from the two entries in the API Operations index page as well please? And finally, I think this change deserves an entry in the Changelog too. Thank you!

Added changelog entry for removing Restricted status
@MikeAdamsMews MikeAdamsMews merged commit 998e55c into master Jun 18, 2024
3 checks passed
@MikeAdamsMews MikeAdamsMews deleted the restrictions-remove-ff branch June 18, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants