Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended product service orders with linked reservation id. #596

Merged
merged 3 commits into from
May 31, 2024

Conversation

prazi
Copy link
Contributor

@prazi prazi commented May 27, 2024

Summary

Follow style guide

Style guide

Check during review

  • The changelog and potentially a deprecation entries are in place.
    • The changelog timestamp is date of merge to develop.
  • JSON example extended.
    • New properties are added to the correct place in the JSON.
  • New properties in the table are added to the correct place.
  • Correct formatting:
    • Spacing is consistent between titles, sections, tables, ...
    • Correct JSON format - indentation.
  • DateTime properties should always be defined in ISO format.

@prazi prazi requested a review from MikeAdamsMews May 27, 2024 12:29
@prazi prazi self-assigned this May 27, 2024
@prazi prazi requested review from a team as code owners May 27, 2024 12:29
@prazi
Copy link
Contributor Author

prazi commented May 30, 2024

@MikeAdamsMews could you please check this one? 🙏🏼

Co-authored-by: Jonas Pauliukevičius <jonas.pauliukevicius@mews.com>
@prazi prazi merged commit ace92e2 into master May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants