Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update advanced search filter with AMS labels #2

Open
cboelling opened this issue Jan 21, 2021 · 3 comments
Open

Update advanced search filter with AMS labels #2

cboelling opened this issue Jan 21, 2021 · 3 comments
Labels
web interface Concerns the AAD web interface

Comments

@cboelling
Copy link
Member

The advanced search page needs to be updated with the new labels for the metadata elements in audiogram_metadata_scheme.md.

This might also give us an opportunity to check if the labels as they are used to define the scheme can be at once used for the database interface.

@cboelling cboelling added the web interface Concerns the AAD web interface label Jan 21, 2021
@alvarosaurus
Copy link
Collaborator

alvarosaurus commented Jan 21, 2021

For starts, "Species" is not enough for the UI, since the UI has to list English and Latin names.
Also, the UI should include information about the unit, e.g. age in months. As does the database.
I'll see how far I get with the rest. However, if the scheme doesn't fit the use case, then we should change the scheme rather than the UI.

@cboelling
Copy link
Member Author

For starts, "Species" is not enough for the UI, since the UI has to list English and Latin names.
Also, the UI should include information about the unit, e.g. age in months. As does the database.
I'll see how far I get with the rest. However, if the scheme doesn't fit the use case, then we should change the scheme rather than the UI.

Agreed. Perhaps one way to proceed is to check if the term used in the metadata scheme can be used and appended by the additional information that's necessary, e.g.,

species English vernacular name OR species (English vernacular name)

The idea is that for those elements in th UI which correspond to elements in the metadata scheme the correspondence should be recognizable quickly and unambiguously.

We can certainly also adapt the terms in the metadata scheme if that turns out to be the better solution.

@alvarosaurus
Copy link
Collaborator

Some comments on the names used in the database scheme
This is the database scheme as it is implemented:

+--------------------------------+
| Tables_in_audiogrambase        |
+--------------------------------+
| audiogram_data_point           |
| audiogram_experiment           |
| audiogram_publication          |
| facility                       |
| individual_animal              |
| method                         |
| publication                    |
| sound_pressure_level_reference |
| taxon                          |
| test_animal                    |
+--------------------------------+

For future database implementations, please consider:

  • database name "audiogrambase" is not bad, but there are datasets in the database which are not audiograms
  • 'audiogram_data_point' could be just 'data_point'
  • 'audiogram_experiment' could be 'experiment'
  • 'audiogram_publication' is a linking table between 'audiogram_experiment' and 'publication', so should be 'experiment_publication'
  • 'sound_pressure_level_reference' could be 'spl_reference'
  • 'test_animal' is a linking table between 'individual_animal' and 'audiogram_experiment', so where does 'test' come from?

The general structure of the database is practical, but has limitations, for example when an audiogram is deleted, then undeleting it is not possible, as this would require a more normalized structure (as found in a CMS).

@alvarosaurus alvarosaurus removed their assignment Feb 8, 2021
@cboelling cboelling changed the title Update advanced search filter with new metadata labels Update advanced search filter with AMS labels Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
web interface Concerns the AAD web interface
Projects
None yet
Development

No branches or pull requests

2 participants