Updated Readme for ECS Compatibility and Missing Disc button #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmayer
approved these changes
Jan 10, 2023
zachmayer
suggested changes
Jan 11, 2023
| •Dig Dug | ||
| •Pac-Man | ||
|
|
||
| The disc button has not been implemented or mapped as a button yet. There's a ticket open regarding this: https://github.com/MiSTer-devel/Intv_MiSTer/issues/16 |
There was a problem hiding this comment.
You can remove line 34. The intellivision doesn't actually have a "disk button". The games use input from any one of the 16 disc directions as a "disc press."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing the Intellivision core this morning, I noticed that there are graphical corruption issues when playing games with the ECS switched on. 4 games are unplayable with this switch on. Therefore, I thought it was valuable to update the readme on which games didn't work with the ECS switch on and to recommend turning the ECS switch off for maximum compatibility, unless attempting to play ECS software.
Please kindly consider this pull request.