Minimig: Fixes for shared file system (MiSTerFileSystem) #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renaming a file or directory to its own name is legal under AmigaOS, so ensure that this case is a no-op and returns success. This fixes the error encountered when creating a new drawer under SHARE: and accepting the default name of "Unnamed1", for example.
Adapt upstream fix from a314. This fixes some odd behaviour in Workbench such as: - Icons that were "Left Out" would reappear in their parent windows when refreshed. - Deleted files would not disappear from the window unless it was refreshed. Original message from a314 commit: This call is used in at least 2.1 to terminate directory traversal when deleting a directory using Workbench. This sometimes caused unhandled exceptions in a314d and much worse unintended files being deleted!
Some applications would fail to load some files due to negative seek offsets being corrupted by unsigned conversion. A simple test case is AmigaGuide: place an AmigaGuide document on the shared volume and attempt to open it. Before this patch, this would fail silently.
Adapt upstream fix from a314. Original message: This action is performed when doing a drag-n-drop copy from the PiDisk to an other device in Workbench 3.1.4
Adapt upstream fix from a314. Original message: Using ACTION_FINDINPUT to check if a file exists wrongfully returned ERROR_DIR_NOT_FOUND instead of ERROR_OBJECT_NOT_FOUND if the file was searched for in a non-existent subdirectory.
Only nullify the key in find_path() if the name contains our device (SHARE:) or volume (MiSTer:) name. This fixes the ability to create assigns to locations on the shared filesystem. If find_path() is called with an assign-relative path, we want to preserve the key so that a relative path is constructed from the directory associated with that key.
theypsilon
pushed a commit
to MiSTer-DB9/Main_MiSTer
that referenced
this pull request
Feb 26, 2021
Minimig: Fixes for shared file system (MiSTerFileSystem)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (combined with the accompanying PR to Minimig-AGA_MiSTer) merges some fixes from a314, and a couple of extra fixes that that take care of some of the worst bugs:
Assigncommand to create an assign to a location within the shared file system didn't work correctly - it would always point to the root. This has been fixed.Requires changes to Minimig-AGA_MiSTer (see other PR).