IDE: Semi-implement READ_VERIFY and suppress debug output #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what is the purpose to patch debug output in cdrom? |
This reverts commit efff967.
|
The only reason I changed it in ide_cdrom as well was to be consistent between the two. I have reverted the file. |
theypsilon
pushed a commit
to MiSTer-unstable-nightlies/Main_MiSTer
that referenced
this pull request
Feb 26, 2022
dentnz
pushed a commit
to dentnz/Main_MiSTer
that referenced
this pull request
May 12, 2022
dentnz
pushed a commit
to dentnz/Main_MiSTer
that referenced
this pull request
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a solution for using NTFS under Windows NT on ao486.
Without supporting ATA command 0x40 (READ_VERIFY), NTFS conversion in Windows NT setup (or using convert.exe) gets stuck in an infinite loop. This PR provides an OK response to the 0x40 command although it does not actually provide any verification of a good read.
Additionally there are other unsupported commands which are called by NT during the conversion process which are OK to ignore/fail. However, they occur so rapidly during the conversion loop that this causes a flood of printf debug messages which cause significant slowdown to IDE access. This PR therefore also moves "unknown command" to dbg_printf so they are suppressed by default.