Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Improvement) HDR infoframe replacement with proper BT2020 values #721

Merged
merged 1 commit into from Jan 2, 2023

Conversation

Natrox
Copy link
Contributor

@Natrox Natrox commented Jan 1, 2023

Hello again, and a happy new year to all of you. Thank you for merging the earlier HDR feature.

I kept a close watch on discussion and experiences people had with HDR, and identified some key issues:

  • Blacks may get crushed
  • Very bright parts of an image will clip without scanlines
  • It is impossible to get accurate colors.

After doing some research on the specification of the HDR infoframe, I constructed replacement metadata that matches with BT2020; the bytes for RGB primaries and whitepoint have been corrected for this color space. See the code for parameters used.

Results
People using hdr=1 will now get a more accurate color reproduction in BT2020 color space. The colors will more closely resemble those of SDR while still providing enhanced brightness and contrast. DCI P3 remains available by using hdr=2, but the metadata does not change and will still advertise itself as BT2020. hdr=3 is also usable but requires careful tweaking.

Recommendations
Since BT2020 is now accurate, I recommend users try out hdr=1 again - without any color control options (all default). Previously, a lot of users went with hdr=2 as it provided a better color reproduction.
When using any HDR option, please turn off the gamma filter in "Video Processing". Gamma is already set to 2.2 via the HDR infoframe.


Thank you!

@sorgelig sorgelig merged commit 9276306 into MiSTer-devel:master Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants