PAL SMS border is incorrect over analog video when direct_video=0

[birdybro]

https://misterfpga.org/viewtopic.php?p=48093#p48093

I confirmed this result as well. For some odd reason direct video being enabled fixes the otherwise broken border. the border for PAL is also incorrect over HDMI which leads to the screen being filled with an incorrect aspect ratio.

2022-04-04.21-27-52.mp4

Here's a video of me switching back and forth between two alternate ini's. Both the same, but one has direct_video=1 and shows the correct border. This is using the analog IO board with vga to YPbPr going to a retrotink 5x pro scaler.

[birdybro]

I traced it down, it's a regression linked to this commit --> cbef92c

[birdybro]

Following up on this so I don't lose track and don't forget, the issue is related to the regression I linked, but also paulb-nl mentioned that this is due to the 5x mode being forced. Kitrinx has the workings of a fix here, others and I were testing it for her, but she has yet to submit a PR, shes' probably wanting to finish it up some more. --> Kitrinx@41c4d1e

Next, after this is all fixed, then the exact resolutions should be validated for every mode. After that a math-derived aspect ratio for the scaler can be done similar to how the Sega Genesis core has a combinational block for that --> https://github.com/MiSTer-devel/Genesis_MiSTer/blob/ad60161e0d298b794b52a5ad84be355a2cbed88c/Genesis.sv#L194-L219

[birdybro]

This is resolved and will be available in the next release, closing.