Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beavis and Butthead anti-piracy still in effect #261

Closed
soullos opened this issue Mar 5, 2021 · 5 comments
Closed

Beavis and Butthead anti-piracy still in effect #261

soullos opened this issue Mar 5, 2021 · 5 comments

Comments

@soullos
Copy link

soullos commented Mar 5, 2021

Beavis and Butthead has what I understand an anti-piracy effect where any point of damage will result in an instant death. I use to own the original cart and it was never like that. Normally you'd lose a bit of life from your life bar when getting damaged. To reproduce it, just load up any level and get hit. It's one hit kills so pretty easy to reproduce.

A few users on the MiSTer discord said it might be a case of a memory read issue. I've tried changing the "Initial WRAM" options in the Hardware menu in the core but neither option works. I've switched to each option, reset the game, and that had no effect. I've tried switching to each option during a single play through after each death, but that likewise had no effect. Interestingly, when I load the game in Retroarch on my PC, the one hit kill effect is gone, you take damage as you should. Not quite sure what it could be, just bringing attention to it. Let me know if anyone needs more info and whatnot.

Thanks. :)

@paulb-nl
Copy link
Contributor

paulb-nl commented Mar 6, 2021

The game does a SBC $0200 in decimal mode to subtract 1 from the life bar but the MiSTer core calculates the wrong result. With Mesen-S the result of $0B - $01 in decimal mode is $0A but here the result is $94.

If I enable a cheat that sets the $0222 value to $09 and then disable the cheat then it subtracts correctly (9->0->99) and the life bar works as it should.

bb_sbc_mesen
bb_sbc_mister

@paulb-nl
Copy link
Contributor

paulb-nl commented Mar 8, 2021

Fixed by 5323b12 Thanks @srg320

@birdybro
Copy link
Member

birdybro commented Apr 10, 2021

Current release passes test_adc and test_adc_16, but fails test_sbc and test_sbc_16.

After the recent change this is now the opposite. Is the Beavis and Butthead anti-piracy also relying upon functioning adc behavior concurrent with these test roms?

snes_adc_sbc.zip @srg320

Video of behavior compared -

Videos.zip

Test source --> https://gitlab.com/higan/snes-test-roms/-/tree/master/jonasquinn-test-roms/test_adc_sbc

@birdybro
Copy link
Member

Latest update restores ADC test functionality and retains the new SBC fixes!

Bravo @srg320 👏🏻 !!

@thehughhefner
Copy link

I believe this issue can be closed

@sorgelig sorgelig closed this as completed May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants