Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scancode set 1 switching and Monochrome option #94

Closed
wants to merge 1 commit into from
Closed

Scancode set 1 switching and Monochrome option #94

wants to merge 1 commit into from

Conversation

spark2k06
Copy link
Contributor

  • With the framework duly updated, an actual change to scancode set 1 is now made instead of a scancode translation. Thank you @naeloob for your cooperation and support in developing this feature.

  • Monochrome monitor simulation option for green, amber and B&W. Code reused from Amstrad CPC core.

* With the framework duly updated, an actual change to scancode set 1 is now made instead of a scancode translation. Thank you @naeloob for your cooperation and support in developing this feature.

* Monochrome monitor simulation option for green, amber and B&W. Code reused from Amstrad CPC core.
@sorgelig
Copy link
Member

I cannot accept changes in sys. It cannot be changed.
Also i486 never shipped with BW monitor, so monochrome option is arguable.

@spark2k06
Copy link
Contributor Author

Understood. I make a new PR only with the feature of using SET 1, without code translation... for a cleaner code and adapted to the possibility of changing scancodes of the new proposal in the framework:

#96

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants