Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brute force solution for modules with strange html header #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

p4535992
Copy link
Contributor

No description provided.

@MiahNelah
Copy link
Owner

What module do you need to brute force like this ? Isn't it cleaner to remove all childNodes ?

@p4535992
Copy link
Contributor Author

I verified the behaviuor with this module: https://github.com/misterpotts/fabricate/releases/download/0.10.24/module.json

@MiahNelah
Copy link
Owner

I tried this module with and without your PR: I see no difference. Everything works as expected, even without your modifications. I have no issues at all. What behavior do you notice ? Have you an error ?

Maybe you just have an issue related to delay before header's cleaning is applied. Try to raise delay here to something like 500ms and test again.

If real issue is delay, I'll add a slider in settings to allow an easy adjustement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants