Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make gitlab updater work by tag when releases are disabled #219

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

lilyinstarlight
Copy link
Contributor

If a GitLab repository has the "Releases" feature disabled (such as vcard), the updater currently fails with KeyError: 'release' since the release key is removed from the API

This allows it to gracefully fall back to using tags even if releases are disabled

@l0b0 l0b0 mentioned this pull request Jan 17, 2024
13 tasks
@Mic92
Copy link
Owner

Mic92 commented Jan 17, 2024

@mergify queue

Copy link
Contributor

mergify bot commented Jan 17, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 6e4ee69

@mergify mergify bot merged commit 6e4ee69 into Mic92:master Jan 17, 2024
4 checks passed
@lilyinstarlight lilyinstarlight deleted the fix/gitlab-releases-disabled branch January 17, 2024 14:57
@l0b0
Copy link

l0b0 commented Jan 17, 2024

@Mic92 Would you be OK to do a release for nixpkgs/pkgs/tools/package-management/nix-update/default.nix b/pkgs/tools/package-management/nix-update/default.nix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants