Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing extra arguments to import <nixpkgs> #314

Closed
SomeoneSerge opened this issue Feb 27, 2023 · 2 comments · Fixed by #315
Closed

Allow passing extra arguments to import <nixpkgs> #314

SomeoneSerge opened this issue Feb 27, 2023 · 2 comments · Fixed by #315
Labels
enhancement New feature or request

Comments

@SomeoneSerge
Copy link

Use-case: running nixpkgs-review with config.cudaSupport = true and custom config.cudaCapabilities.
Currently, nixpkgs-review only tracks affected cuda-enabled packages if they expose a xxxWithCuda attribute in nixpkgs.
Not all packages do that, and it's debatable whether they should.

I think a satisfiable solution would be e.g. being able to run nixpkgs-review pr XXXXXX --extra-nixpkgs-config '{ config.cudaSupport = true; }'. I imagine nixpkgs-review could explicitly state any extra options it has received in the report that it publishes as a github comment, since these options could (and do) affect the eval

@figsoda figsoda added the enhancement New feature or request label Feb 27, 2023
@figsoda
Copy link
Collaborator

figsoda commented Feb 27, 2023

#315

@bors bors bot closed this as completed in #315 Mar 16, 2023
@SomeoneSerge
Copy link
Author

Thank you @figsoda!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants