-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using token from GitHub CLI (gh) doesn't seem to work #332
Comments
it might have something to do with cli/cli#7276 |
Seems like the keyring is now used for storage: |
Also encountered this on a freshly-installed NixOS instance. A temporary fix is to |
https://github.com/zalando/go-keyring is used in the GitHub CLI to access the keyring, I wonder if nixpkgs-review can (is allowed to) load the token of the GitHub CLI. |
Is there some cli tools present in those desktop environments to easily access keyrings? Otherwise I would just start adding a nixpkgs-review configuration to store secrets (maybe using python's new toml parser). |
I wouldn't bother, if you want to execute a CLI tool you can as well run |
Ah. I wasn't aware of this option. |
Thank you very much! |
Thank you for this wonderful way to test PRs!
Although, using the token from GitHub CLI (gh) doesn't seem to work for me.
nixpkgs-review-2.9.1 from the nix store.
gh version 2.29.0 (1980-01-01) from the nix store.
I'm logged in into gh (just got a fresh token again).
But my
~/.config/gh/hosts.yml
looks like this, no token there:nixpkgs-review says:
The text was updated successfully, but these errors were encountered: