Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow system-wide installation of innosetup installer #103

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Allow system-wide installation of innosetup installer #103

merged 1 commit into from
Jul 25, 2022

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Jul 24, 2022

Some would want to have MicaForEveryone installed system-wide:
image

@xmine64
Copy link
Member

xmine64 commented Jul 24, 2022

I tried this first but it breaks /S parameter support that's needed to install silently with winget.

@sitiom
Copy link
Contributor Author

sitiom commented Jul 24, 2022

You need to pass /ALLUSERS or /CURRENTUSER for it to work. See Setup Command Line Parameters:

/ALLUSERS
Instructs Setup to install in administrative install mode. Only has an effect when the [Setup] section directive PrivilegesRequiredOverridesAllowed allows the commandline override.

/CURRENTUSER
Instructs Setup to install in non administrative install mode. Only has an effect when the [Setup] section directive PrivilegesRequiredOverridesAllowed allows the commandline override.

@xmine64
Copy link
Member

xmine64 commented Jul 24, 2022

You need to pass /ALLUSERS or /CURRENTUSER for it to work.

Ok, thanks. Did you do it in your #102?

@sitiom
Copy link
Contributor Author

sitiom commented Jul 24, 2022

No. The action only uses YamlCreate.ps1 to update the installer links to the new versions. A PR must be created to add the new flags (just add it alongside the PR created from the action when you make a new release).

@xmine64
Copy link
Member

xmine64 commented Jul 24, 2022

We need to be able add custom fields to manifest to make it work, but it is not possible using winget-releaser.

@sitiom
Copy link
Contributor Author

sitiom commented Jul 24, 2022

We need to be able add custom fields to manifest to make it work, but it is not possible using winget-releaser.

Winget releaser just updates the links, you can directly PR to winget-pkgs for that.

@xmine64
Copy link
Member

xmine64 commented Jul 24, 2022

Winget releaser just updates the links, you can directly PR to winget-pkgs for that.

Cool, then I'll do it soon.

@sitiom
Copy link
Contributor Author

sitiom commented Jul 24, 2022

Winget releaser just updates the links, you can directly PR to winget-pkgs for that.

Cool, then I'll do it soon.

You can include the change in the PR that winget releaser will generate in the next release.

@sitiom
Copy link
Contributor Author

sitiom commented Jul 24, 2022

@xmine64 Just a note, I'm currently adding additional information on the current MicaForEveryone package (microsoft/winget-pkgs#67360). In my experience, YAMLCreate.ps1 is better than wingetcreate in creating packages, which is what the winget releaser action is also using.

@sitiom
Copy link
Contributor Author

sitiom commented Jul 25, 2022

@xmine64 Just a note, I'm currently adding additional information on the current MicaForEveryone package (microsoft/winget-pkgs#67360). In my experience, YAMLCreate.ps1 is better than wingetcreate in creating packages, which is what the winget releaser action is also using.

Done. Can you merge this now?

@xmine64 xmine64 merged commit 68cfe5c into MicaForEveryone:master Jul 25, 2022
@sitiom sitiom deleted the install-mode branch July 25, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants