Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a new config file parser #8

Merged
merged 10 commits into from
Dec 30, 2021
Merged

implement a new config file parser #8

merged 10 commits into from
Dec 30, 2021

Conversation

xmine64
Copy link
Member

@xmine64 xmine64 commented Dec 29, 2021

No description provided.

Copy link
Member Author

@xmine64 xmine64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I thought I can use ParserError.Token to show more details about error, but it remained useless.

I was saving it in UI thread
* Catch parser errors and don't panic when there's an error in config file
* Stop hook while config file is reloading
@xmine64 xmine64 merged commit 44177dd into master Dec 30, 2021
@xmine64 xmine64 deleted the newconfig branch December 30, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants