Support for setting corner preference #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlvm
changed the title
|
Thanks, a v1.1.0.0 is coming |
|
We would need translators though |
|
Updated Russian translation in general and translated the new strings. |
|
Remove line 17 ( |
Oh, I meant |
After I've removed this line, also properly shows icons on Windows 10, including tray icon menu: |
Fixed an issue when icons were not displaying on Windows 10
- Update WinUI 2. - Explicitly add WebView2 as a package. - Fix architecture mismatch within packaging project.
|
Wait somehow Visual Studio messed up and created a |
|
Please add translations for these: <data name="CornerMenu.Text" xml:space="preserve">
<value>Corner Mode</value>
</data>
<data name="CornerPreferenceSetting.Header" xml:space="preserve">
<value>Corner Mode</value>
</data>
<data name="SquareMenuItem.Text" xml:space="preserve">
<value>Square</value>
</data>
<data name="RoundedMenuItem.Text" xml:space="preserve">
<value>Rounded</value>
</data>
<data name="RoundedSmallMenuItem.Text" xml:space="preserve">
<value>Slightly Rounded</value>
</data>
<data name="CornerDescription.Text" xml:space="preserve">
<value>Set corner rounding mode,</value>
</data>
<data name="DefaultCornerDescription.Text" xml:space="preserve">
<value>Default doesn't do anything to keep app's preferred corner rounding mode.</value>
</data>
<data name="SquareCornerDescription.Text" xml:space="preserve">
<value>Square mode disables corner rounding.</value>
</data>
<data name="RoundedCornerDescription.Text" xml:space="preserve">
<value>Rounded mode enables rounded corners by force.</value>
</data>
<data name="RoundedSmallCornerDescription.Text" xml:space="preserve">
<value>Slightly rounded mode is in the middle between square and rounded corners.</value>
</data> |
xmine64
reviewed
Jul 1, 2022
|
It makes thing look kinda off, I would say.
|
|
You can see it's using wrong icon:
|
This reverts commit fef8875.
|
How about E179?
|
We would need separate icons for Windows 10 and Windows 11. Let's just embed Segoe Fluent Icons in app but not in this PR. |
|
That would still require a modification to the `App.xaml` file though.
|
|
I have already translated the new strings to Russian |
uDEV2019
added a commit
to uDEV2019/MicaForEveryone
that referenced
this pull request
Jul 1, 2022
as desired in MicaForEveryone#91
|
Hi,
Of course:
…------------------------------------------------
* <data name="CornerMenu.Text" xml:space="preserve">
<value>Personnalisation des coins</value> </data> <data
name="CornerPreferenceSetting.Header" xml:space="preserve">
<value>Personnalisation des coins</value> </data> <data
name="SquareMenuItem.Text" xml:space="preserve"> <value>Carré</value>
</data> <data name="RoundedMenuItem.Text" xml:space="preserve">
<value>Arrondi</value> </data> <data name="RoundedSmallMenuItem.Text"
xml:space="preserve"> <value>Légèrement arrondi</value> </data> <data
name="CornerDescription.Text" xml:space="preserve"> <value>Définir le
mode arrondi des coins,</value> </data> <data
name="DefaultCornerDescription.Text" xml:space="preserve">
<value>"Défaut" ne conserve pas le mode arrondi des coins préféré dans
l'application.</value> </data> <data name="SquareCornerDescription.Text"
xml:space="preserve"> <value>"Carré" désactive l'arrondi des
coins.</value> </data> <data name="RoundedCornerDescription.Text"
xml:space="preserve"> <value>"Arrondi" force l'activation des coins
arrondis.</value> </data> <data name="RoundedSmallCornerDescription.Text"
xml:space="preserve"> <value>"légèrement arrondi" active les coins
semi-arrondis.</value> </data>*
------------------------------------------------
a small question: if in the future I want to propose an update of my
translation, how should I go about sending it to you? directly by email? or
by opening a "ticket" on the Mica GitHub repository?
thanks for your answer ++
Le ven. 1 juil. 2022 à 12:14, Mohammad Amin ***@***.***> a
écrit :
Translate these:
@xoascf <https://github.com/xoascf> @Danik2343
<https://github.com/Danik2343> @maboroshin <https://github.com/maboroshin>
@alessandrocaseti <https://github.com/alessandrocaseti> @uDEV2019
<https://github.com/uDEV2019> @AndromedaMelody
<https://github.com/AndromedaMelody> @SaiyajinK
<https://github.com/SaiyajinK>
<data name="CornerMenu.Text" xml:space="preserve">
<value>Corner Mode</value>
</data>
<data name="CornerPreferenceSetting.Header" xml:space="preserve">
<value>Corner Mode</value>
</data>
<data name="SquareMenuItem.Text" xml:space="preserve">
<value>Square</value>
</data>
<data name="RoundedMenuItem.Text" xml:space="preserve">
<value>Rounded</value>
</data>
<data name="RoundedSmallMenuItem.Text" xml:space="preserve">
<value>Slightly Rounded</value>
</data>
<data name="CornerDescription.Text" xml:space="preserve">
<value>Set corner rounding mode,</value>
</data>
<data name="DefaultCornerDescription.Text" xml:space="preserve">
<value>Default doesn't do anything to keep app's preferred corner rounding mode.</value>
</data>
<data name="SquareCornerDescription.Text" xml:space="preserve">
<value>Square mode disables corner rounding.</value>
</data>
<data name="RoundedCornerDescription.Text" xml:space="preserve">
<value>Rounded mode enables rounded corners by force.</value>
</data>
<data name="RoundedSmallCornerDescription.Text" xml:space="preserve">
<value>Slightly rounded mode is in the middle between square and rounded corners.</value>
</data>
—
Reply to this email directly, view it on GitHub
<#91 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZIQDAV54536OLIUBJRXBELVR3AGXANCNFSM5Z34T7CA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
xmine64
added a commit
that referenced
this pull request
Jul 7, 2022
Add CornerPreference field to default config file as added in #91.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to set corner preference on build 22000 and higher using the DwmSetWindowAttribute API with DWMWA_WINDOW_CORNER_PREFERENCE as attribute and DWM_WINDOW_CORNER_PREFERENCE as value.