Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heat index "feels like" reporting inaccurate numbers #1263

Closed
parnic opened this issue Apr 18, 2018 · 4 comments
Closed

Heat index "feels like" reporting inaccurate numbers #1263

parnic opened this issue Apr 18, 2018 · 4 comments

Comments

@parnic
Copy link
Contributor

parnic commented Apr 18, 2018

Platform: Windows 10 (run from WSL Bash) and viewed with Chrome 65. Also seen with RPi Zero W host with Midori 0.4.3 browser.

Node Version: Seen with LTS 8.10.0 and 8.11.1

MagicMirror Version: 2.3.1

Description: "Feels like" heat index on the currentweather module is reporting wildly inaccurate values in Fahrenheit.

image

Steps to Reproduce: Use the following currentweather config and hope that it's still hot outside. :)

                                location: "McKinney",
                                locationID: "4710178",
                                appid: "your app id",
                                roundTemp: true,
                                appendLocationNameToHeader: false

Expected Results: A (more or less) accurate "feels like" temperature.

Actual Results: Fatal heat levels.

Configuration: See 'steps to reproduce'. Global config uses units: "imperial",

@nhubbard
Copy link
Contributor

@parnic Good PR! I will approve momentarily. This causes some unbelievably funny issues without your fix, especially in Kelvin (default).

@nhubbard
Copy link
Contributor

Specifically, temperatures of nearly 1500 degrees outside.

@parnic
Copy link
Contributor Author

parnic commented Apr 25, 2018

I didn't modify how it was treating Kelvin, so an additional change may be necessary.

@MichMich
Copy link
Collaborator

MichMich commented May 1, 2018

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants