Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Base URL to only accept the correct URL #40

Open
husjon opened this issue Apr 19, 2024 · 0 comments
Open

Update Base URL to only accept the correct URL #40

husjon opened this issue Apr 19, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@husjon
Copy link
Collaborator

husjon commented Apr 19, 2024

The Base URL input should automatically capture the required parameters.

The accepted URL as mentioned in the readme is https://www.goodreads.com/review/list_rss/<USER_ID>?key=<MY_KEY>&shelf=, whereas everything after &shelf= should be omitted as it will be handled by the Your Goodread shelfs option.

I think doing a regex capture of the above URL and stripping off anything else would help reducing the chance of mistakes (e.g #14).

@husjon husjon added the enhancement New feature or request label Apr 19, 2024
@husjon husjon changed the title Update Base URL only accept the correct URL Update Base URL to only accept the correct URL Apr 19, 2024
@husjon husjon self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant